Write transition to bootstrap pipe if the transition is for bootstrap #6357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a 'write to closed pipe' error where we were writing to `transition_writer_ref`, then mutating it and `kill`ing all of the pipes that the `Transition_frontier_controller` writes to when it goes to handle the message. The underlying error is that we were (correctly) closing the transition frontier controller and opening a bootstrap controller, but (incorrectly) sending the message to the writer pipe before updating it to point to the bootstrap controller. This behaviour matches the original version from pre-#3974.
mrmr1993
added
the
ci-build-me
psteckler
approved these changes
Oct 13, 2020
5 tasks
|
Deploy preview for mina-staging ready! Built with commit 4b0bee8 |
This was referenced Oct 13, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a 'write to closed pipe' error where we were writing to
transition_writer_ref, then mutating it andkilling all of the pipesthat the
Transition_frontier_controllerwrites to when it goes tohandle the message.
The underlying error is that we were (correctly) closing the transition
frontier controller and opening a bootstrap controller, but
(incorrectly) sending the message to the writer pipe before updating it
to point to the bootstrap controller. This behaviour matches the
original version from pre-#3974.
Edit: the diff is inflated by format changes; the diff without whitespace changes is much more indicative of what has changed.
Checklist: